Skip to content

feat: add support for multiple dns zones #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2025
Merged

feat: add support for multiple dns zones #1073

merged 4 commits into from
Oct 27, 2025

Conversation

@Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Oct 25, 2025 •
edited
Loading

Description

Issue: #1070

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content
  • Add support for multiple dns zones and ability to set multiple dns records for each of the dns zones.

UPGRADE NOTES: When updating from v8.7.x to this version, if you have a DNS zone and DNS records created, these resources will be recreated. In case, you need to prevent recreation of the DNS zone and DNS records, use the following terraform move commands based on the environment you are running the terraform module.
Terraform CLI:

terraform state mv 'module.<module-name>.ibm_dns_zone.dns_zone[0]' 'module.<module-name>.ibm_dns_zone.dns_zone["<dns-name>"]'
terraform state mv 'module.<module-name>.ibm_dns_permitted_network.dns_permitted_network[0]' 'module.<module-name>.ibm_dns_permitted_network.dns_permitted_network["<dns-name>"]'
terraform state mv 'module.<module-name>.ibm_dns_resource_record.dns_record["0"]' 'module.<module-name>.ibm_dns_resource_record.dns_record["<dns-name>-0"]'
terraform state mv 'module.<module-name>.ibm_dns_resource_record.dns_record["1"]' 'module.<module-name>.ibm_dns_resource_record.dns_record["<dns-name>-1"]'
terraform state mv 'module.<module-name>.ibm_dns_resource_record.dns_record["2"]' 'module.<module-name>.ibm_dns_resource_record.dns_record["<dns-name>-2"]'
terraform state mv 'module.<module-name>.ibm_dns_resource_record.dns_record["3"]' 'module.<module-name>.ibm_dns_resource_record.dns_record["<dns-name>-3"]'
...

Schematics:

ibmcloud schematics workspace state mv --id <WORKSPACE_ID> --source 'module.<module-name>.ibm_dns_zone.dns_zone[0]' --destination 'module.<module-name>.ibm_dns_zone.dns_zone["<dns-name>"]'
ibmcloud schematics workspace state mv --id <WORKSPACE_ID> --source 'module.<module-name>.ibm_dns_permitted_network.dns_permitted_network[0]' --destination 'module.<module-name>.ibm_dns_permitted_network.dns_permitted_network["<dns-name>"]'
ibmcloud schematics workspace state mv --id <WORKSPACE_ID> --source 'module.<module-name>.ibm_dns_resource_record.dns_record["0"]' --destination 'module.<module-name>.ibm_dns_resource_record.dns_record["<dns-name>-0"]'
ibmcloud schematics workspace state mv --id <WORKSPACE_ID> --source 'module.<module-name>.ibm_dns_resource_record.dns_record["1"]' --destination 'module.<module-name>.ibm_dns_resource_record.dns_record["<dns-name>-1"]'
ibmcloud schematics workspace state mv --id <WORKSPACE_ID> --source 'module.<module-name>.ibm_dns_resource_record.dns_record["2"]' --destination 'module.<module-name>.ibm_dns_resource_record.dns_record["<dns-name>-2"]'
ibmcloud schematics workspace state mv --id <WORKSPACE_ID> --source 'module.<module-name>.ibm_dns_resource_record.dns_record["3"]' --destination 'module.<module-name>.ibm_dns_resource_record.dns_record["<dns-name>-3"]'
...

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J Aashiq-J mentioned this pull request Oct 25, 2025
Closed
@Aashiq-J
Copy link
Member Author

/run pipeline

maheshwarishikha
maheshwarishikha reviewed Oct 27, 2025
View reviewed changes
@Aashiq-J
Copy link
Member Author

/run pipeline

1 similar comment
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@maheshwarishikha maheshwarishikha merged commit 005e9cc into main Oct 27, 2025
2 checks passed
@maheshwarishikha maheshwarishikha deleted the dns branch October 27, 2025 12:56
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ocofaigh
Copy link
Contributor

As per https://terraform-ibm-modules.github.io/documentation/#/versioning?id=major-version-changes this should have been a major version release since we are requesting customers to run moved commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maheshwarishikha maheshwarishikha maheshwarishikha approved these changes

@rajatagarwal-ibm rajatagarwal-ibm Awaiting requested review from rajatagarwal-ibm rajatagarwal-ibm is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Aashiq-J @terraform-ibm-modules-ops @ocofaigh @maheshwarishikha